Call NotifyStableBranchCreation when stable branch is created (!2672) · Merge requests · GitLab.org / release-tools

Reuben Pereira requested to merge rp/notify-stable-branch-creation2 into master Oct 03, 2023

What does this MR do and why?

Describe in detail what your merge request does and why.

Content

Call NotifyStableBranchCreation to post comments to security issues when the stable branch is created, so that security issue assignees are reminded to create a backport targeting the new stable branch.

This MR adds a call to NotifyStableBranchCreation in the create_target_branch method of the PublicRelease::Release module. The PublicRelease::Release module is used for releasing all projects (except gitlab-org/gitlab).

Since the create_target_branch method is not used in PublicRelease::GitlabRelease, we also call NotifyStableBranchCreation in PublicRelease::GitlabRelease#create_ee_target_branch.

The NotifyStableBranchCreation class was added in !2659 (merged).

An example comment posted to an issue can be seen at https://gitlab.com/gitlab-org/security/gitlab/-/issues/971#note_1591986433.

gitlab-com/gl-infra/delivery#19629 (closed)

Testing

I tested by applying the following diff to my local release-tools project, and running the following rake task: TEST=true RELEASE_BOT_OPS_TOKEN='token' RELEASE_BOT_PRODUCTION_TOKEN='token' bundle exec rake 'release:tag[16.5.0-rc42]'.

Since this is a dry-run execution, log lines saying Posting stable branch creation notification to issue indicate that the comment would have been posted to the issue.

diff --git a/lib/release_tools/gitlab_client.rb b/lib/release_tools/gitlab_client.rb
index 4d6a8d5e..f1cac1e4 100644
--- a/lib/release_tools/gitlab_client.rb
+++ b/lib/release_tools/gitlab_client.rb
@@ -294,6 +294,7 @@ module ReleaseTools
     #
     # Returns a Gitlab::ObjectifiedHash object, or nil
     def self.find_branch(branch_name, project = Project::GitlabCe)
+      return true if branch_name.include?('16-5-stable')
       client.branch(project_path(project), branch_name)
     rescue Gitlab::Error::NotFound
       nil
diff --git a/lib/release_tools/security/issue_crawler.rb b/lib/release_tools/security/issue_crawler.rb
index 6c189910..3f5fdba8 100644
--- a/lib/release_tools/security/issue_crawler.rb
+++ b/lib/release_tools/security/issue_crawler.rb
@@ -113,11 +113,15 @@ module ReleaseTools
       end
 
       def notifiable_security_issues_for(project)
-        found_issues = GitlabClient.issues(
-          project.security_path,
-          labels: [SECURITY_NOTIFICATIONS_LABEL],
-          state: OPENED
-        )
+        found_issues = [
+          ReleaseTools::GitlabClient.issue('gitlab-org/security/gitlab', 970),
+          ReleaseTools::GitlabClient.issue('gitlab-org/security/gitlab', 971)
+        ]
+        # found_issues = GitlabClient.issues(
+        #   project.security_path,
+        #   labels: [SECURITY_NOTIFICATIONS_LABEL],
+        #   state: OPENED
+        # )
 
         security_issues_and_merge_requests_for(found_issues)
       end
diff --git a/lib/release_tools/security/notify_stable_branch_creation.rb b/lib/release_tools/security/notify_stable_branch_creation.rb
index e9e4b984..a20b1a73 100644
--- a/lib/release_tools/security/notify_stable_branch_creation.rb
+++ b/lib/release_tools/security/notify_stable_branch_creation.rb
@@ -43,7 +43,7 @@ module ReleaseTools
       end
 
       def post_notification(issue)
-        logger.info('Posting stable branch creation notification to issue', issue: issue.web_url, stable_branch_name: stable_branch_name)
+        logger.info('Posting stable branch creation notification to issue', issue: issue.web_url, stable_branch_name: stable_branch_name, body: note_body(issue))
 
         return if SharedStatus.dry_run?

The log lines output on running the rake task.

2023-10-04 19:48:02.750757 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:02 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags" - 
2023-10-04 19:48:04.251404 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:04 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags?id=gitlab-org%2Fsecurity%2Fcharts%2Fgitlab&order_by=updated&page=2&per_page=100&search=%5Ev&sort=desc" - 
2023-10-04 19:48:05.402415 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:05 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags?id=gitlab-org%2Fsecurity%2Fcharts%2Fgitlab&order_by=updated&page=3&per_page=100&search=%5Ev&sort=desc" - 
2023-10-04 19:48:06.781249 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:06 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags?id=gitlab-org%2Fsecurity%2Fcharts%2Fgitlab&order_by=updated&page=4&per_page=100&search=%5Ev&sort=desc" - 
2023-10-04 19:48:08.093494 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:08 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags?id=gitlab-org%2Fsecurity%2Fcharts%2Fgitlab&order_by=updated&page=5&per_page=100&search=%5Ev&sort=desc" - 
📦 Gitaly release
2023-10-04 19:48:09.377479 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:09 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fcharts%2Fgitlab/repository/tags?id=gitlab-org%2Fsecurity%2Fcharts%2Fgitlab&order_by=updated&page=6&per_page=100&search=%5Ev&sort=desc" - 
2023-10-04 19:48:09.381228 I [dry-run] ReleaseTools::PublicRelease::GitalyMonthlyRelease -- Starting release of Gitaly -- {:version=>"16.5.0-rc42"}
2023-10-04 19:48:11.023991 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:11 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitaly/deployments" - 
2023-10-04 19:48:11.032848 I [dry-run] ReleaseTools::PublicRelease::GitalyMonthlyRelease -- Last production commit via project deployments -- {:project=>"gitlab-org/gitaly", :sha=>"8e9a11bede2d946964dc9a58c5e28952dc78ea86"}
2023-10-04 19:48:11.032988 I [dry-run] ReleaseTools::PublicRelease::GitalyMonthlyRelease -- Creating target branch -- {:project=>"gitlab-org/gitaly", :source=>"8e9a11bede2d946964dc9a58c5e28952dc78ea86", :branch=>"16-5-stable"}
2023-10-04 19:48:11.033038 I [dry-run] ReleaseTools::PublicRelease::GitalyMonthlyRelease -- Checking if project and version are eligible for stable branch creation notification -- {:project=>gitlab-org/gitaly, :version=>"16.5.0-rc42"}
2023-10-04 19:48:11.033177 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:11.033625 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:11.701287 I [dry-run] ReleaseTools::PublicRelease::GitalyMonthlyRelease -- Checking if target branch is the stable branch for current monthly release -- {:stable_branch_name=>"16-5-stable", :target_branch=>"16-5-stable"}
2023-10-04 19:48:11.701378 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting notification to security issues about creation of stable branch -- {:stable_branch_name=>"16-5-stable", :project=>gitlab-org/gitaly}
2023-10-04 19:48:13.025540 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:13 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/970" - 
2023-10-04 19:48:13.641135 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:13 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/971" - 
2023-10-04 19:48:14.662891 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:14 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/related_merge_requests" - 
2023-10-04 19:48:15.391224 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:15 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/related_merge_requests" - 
2023-10-04 19:48:16.199865 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:16 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/notes" - 
2023-10-04 19:48:16.820575 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:16 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/issues" - 
2023-10-04 19:48:16.820882 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/970", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}
2023-10-04 19:48:17.471043 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:17 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/notes" - 
2023-10-04 19:48:17.471732 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/971", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}

📦 GitLab Pages release
2023-10-04 19:48:17.472042 I [dry-run] ReleaseTools::PublicRelease::GitlabPagesRelease -- Starting release of gitlab-pages -- {:version=>"16.5.0-rc42"}
2023-10-04 19:48:18.840749 D [dry-run] ReleaseTools::GitlabOpsClient -- [HTTParty] [2023-10-04 19:48:18 +0530] 200 "GET https://ops.gitlab.net/api/v4/projects/gitlab-org%2Frelease%2Fmetadata/deployments" - 
2023-10-04 19:48:18.841483 I [dry-run] ReleaseTools::ProductVersion -- Fetching release metadata commit -- {:sha=>"c1eb107894b17b39a77db52d8704281ab91bfb66"}
2023-10-04 19:48:20.041321 D [dry-run] ReleaseTools::GitlabOpsClient -- [HTTParty] [2023-10-04 19:48:20 +0530] 200 "GET https://ops.gitlab.net/api/v4/projects/gitlab-org%2Frelease%2Fmetadata/repository/commits/c1eb107894b17b39a77db52d8704281ab91bfb66/diff" - 
2023-10-04 19:48:20.041646 I [dry-run] ReleaseTools::ProductVersion -- Fetching release metadata -- {:version=>"16.5.202310040605"}
2023-10-04 19:48:21.321551 D [dry-run] ReleaseTools::GitlabOpsClient -- [HTTParty] [2023-10-04 19:48:21 +0530] 200 "GET https://ops.gitlab.net/api/v4/projects/gitlab-org%2Frelease%2Fmetadata/repository/files/releases%2F16%2F16.5.202310040605.json" - 
2023-10-04 19:48:21.321708 I [dry-run] ReleaseTools::PublicRelease::GitlabPagesRelease -- Last production commit via metadata -- {:project=>"gitlab-org/gitlab-pages", :sha=>"eadd269e8d53425f090fa059a7cd30c266bde8a7"}
2023-10-04 19:48:21.321740 I [dry-run] ReleaseTools::PublicRelease::GitlabPagesRelease -- Creating target branch -- {:project=>"gitlab-org/gitlab-pages", :source=>"eadd269e8d53425f090fa059a7cd30c266bde8a7", :branch=>"16-5-stable"}
2023-10-04 19:48:21.321752 I [dry-run] ReleaseTools::PublicRelease::GitlabPagesRelease -- Checking if project and version are eligible for stable branch creation notification -- {:project=>gitlab-org/gitlab-pages, :version=>"16.5.0-rc42"}
2023-10-04 19:48:21.321772 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:21.321835 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:21.738980 I [dry-run] ReleaseTools::PublicRelease::GitlabPagesRelease -- Checking if target branch is the stable branch for current monthly release -- {:stable_branch_name=>"16-5-stable", :target_branch=>"16-5-stable"}
2023-10-04 19:48:21.739023 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting notification to security issues about creation of stable branch -- {:stable_branch_name=>"16-5-stable", :project=>gitlab-org/gitlab-pages}
2023-10-04 19:48:22.446484 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:22 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/970" - 
2023-10-04 19:48:23.181316 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:23 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/971" - 
2023-10-04 19:48:24.251038 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:24 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/related_merge_requests" - 
2023-10-04 19:48:24.541048 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:24 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/related_merge_requests" - 
2023-10-04 19:48:25.272372 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:25 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/notes" - 
2023-10-04 19:48:26.000756 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:26 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/issues" - 
2023-10-04 19:48:26.001053 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/970", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}
2023-10-04 19:48:26.851539 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:26 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/notes" - 
2023-10-04 19:48:26.854322 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/971", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}

📦 GitLab release
2023-10-04 19:48:26.855264 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Starting release of GitLab CE and EE -- {:ee_version=>"16.5.0-rc42-ee", :ce_version=>"16.5.0-rc42"}
2023-10-04 19:48:26.855587 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Creating CE target branch -- {:project=>"gitlab-org/gitlab-foss", :source=>"16-4-stable", :branch=>"16-5-stable"}
2023-10-04 19:48:27.463960 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:27 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/deployments" - 
2023-10-04 19:48:27.464320 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Last production commit via project deployments -- {:project=>"gitlab-org/gitlab", :sha=>"4df573af3473f68ac34466f1806fbcf8cd81f5c0"}
2023-10-04 19:48:27.464359 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Creating EE target branch -- {:project=>"gitlab-org/gitlab", :source=>"4df573af3473f68ac34466f1806fbcf8cd81f5c0", :branch=>"16-5-stable-ee"}
2023-10-04 19:48:27.464372 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Checking if project and version are eligible for stable branch creation notification -- {:project=>gitlab-org/gitlab, :version=>"16.5.0-rc42-ee"}
2023-10-04 19:48:27.464394 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:27.464457 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:27.625191 I [dry-run] ReleaseTools::PublicRelease::GitlabRelease -- Checking if target branch is the stable branch for current monthly release -- {:stable_branch_name=>"16-5-stable-ee", :target_branch=>"16-5-stable-ee"}
2023-10-04 19:48:27.625248 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting notification to security issues about creation of stable branch -- {:stable_branch_name=>"16-5-stable-ee", :project=>gitlab-org/gitlab}
2023-10-04 19:48:28.921030 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:28 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/970" - 
2023-10-04 19:48:29.515663 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:29 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/971" - 
2023-10-04 19:48:30.833566 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:30 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/related_merge_requests" - 
2023-10-04 19:48:30.852152 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:30 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/related_merge_requests" - 
2023-10-04 19:48:31.559908 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:31 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/notes" - 
2023-10-04 19:48:32.276889 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:32 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/issues" - 
2023-10-04 19:48:32.277094 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/970", :stable_branch_name=>"16-5-stable-ee", :body=>"@rpereira2 The stable branch `16-5-stable-ee` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}
2023-10-04 19:48:33.712537 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:33 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/notes" - 
2023-10-04 19:48:33.714501 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/971", :stable_branch_name=>"16-5-stable-ee", :body=>"@rpereira2 The stable branch `16-5-stable-ee` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}

📦 Omnibus release
2023-10-04 19:48:33.715548 I [dry-run] ReleaseTools::PublicRelease::OmnibusGitlabRelease -- Starting release of Omnibus GitLab -- {:ee_version=>"16.5.0+rc42.ee.0", :ce_version=>"16.5.0+rc42.ce.0"}
2023-10-04 19:48:35.451169 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:35 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fomnibus-gitlab/deployments" - 
2023-10-04 19:48:35.451585 I [dry-run] ReleaseTools::PublicRelease::OmnibusGitlabRelease -- Last production commit via project deployments -- {:project=>"gitlab-org/omnibus-gitlab", :sha=>"dbadfa884496999a22ef954ae31aed78df28ec41"}
2023-10-04 19:48:35.451666 I [dry-run] ReleaseTools::PublicRelease::OmnibusGitlabRelease -- Creating target branch -- {:project=>"gitlab-org/omnibus-gitlab", :source=>"dbadfa884496999a22ef954ae31aed78df28ec41", :branch=>"16-5-stable"}
2023-10-04 19:48:35.451677 I [dry-run] ReleaseTools::PublicRelease::OmnibusGitlabRelease -- Checking if project and version are eligible for stable branch creation notification -- {:project=>gitlab-org/omnibus-gitlab, :version=>"16.5.0+rc42.ee.0"}
2023-10-04 19:48:35.451697 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:35.451770 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:35.641088 I [dry-run] ReleaseTools::PublicRelease::OmnibusGitlabRelease -- Checking if target branch is the stable branch for current monthly release -- {:stable_branch_name=>"16-5-stable", :target_branch=>"16-5-stable"}
2023-10-04 19:48:35.641249 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting notification to security issues about creation of stable branch -- {:stable_branch_name=>"16-5-stable", :project=>gitlab-org/omnibus-gitlab}
2023-10-04 19:48:36.272117 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:36 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/970" - 
2023-10-04 19:48:36.886080 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:36 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/971" - 
2023-10-04 19:48:38.081854 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:38 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/related_merge_requests" - 
2023-10-04 19:48:38.481120 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:38 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/related_merge_requests" - 
2023-10-04 19:48:39.241696 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:39 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/notes" - 
2023-10-04 19:48:39.961334 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:39 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/issues" - 
2023-10-04 19:48:39.962106 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/970", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}
2023-10-04 19:48:40.880711 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:40 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/notes" - 
2023-10-04 19:48:40.882540 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/971", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}

📦 CNG release
2023-10-04 19:48:40.883570 I [dry-run] ReleaseTools::PublicRelease::CNGImageRelease -- Starting release of CNG -- {:version=>"16.5.0-rc42-ee"}
2023-10-04 19:48:40.883849 I [dry-run] ReleaseTools::PublicRelease::CNGImageRelease -- Creating target branch -- {:project=>"gitlab-org/build/CNG", :source=>"master", :branch=>"16-5-stable"}
2023-10-04 19:48:40.883902 I [dry-run] ReleaseTools::PublicRelease::CNGImageRelease -- Checking if project and version are eligible for stable branch creation notification -- {:project=>gitlab-org/build/CNG, :version=>"16.5.0-rc42-ee"}
2023-10-04 19:48:40.883958 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:40.884156 I [dry-run] ReleaseTools::ReleaseManagers::Schedule -- dynamic_release_date feature flag disabled. Using release_managers.yml as source
2023-10-04 19:48:41.061623 I [dry-run] ReleaseTools::PublicRelease::CNGImageRelease -- Checking if target branch is the stable branch for current monthly release -- {:stable_branch_name=>"16-5-stable", :target_branch=>"16-5-stable"}
2023-10-04 19:48:41.061722 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting notification to security issues about creation of stable branch -- {:stable_branch_name=>"16-5-stable", :project=>gitlab-org/build/CNG}
2023-10-04 19:48:41.683030 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:41 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/970" - 
2023-10-04 19:48:42.415988 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:42 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fsecurity%2Fgitlab/issues/971" - 
2023-10-04 19:48:43.438796 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:43 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/related_merge_requests" - 
2023-10-04 19:48:43.851086 D ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:43 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/related_merge_requests" - 
2023-10-04 19:48:45.490014 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:45 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/970/notes" - 
2023-10-04 19:48:46.126425 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:46 +0530] 200 "GET https://gitlab.com/api/v4/projects/gitlab-org%2Fgitlab/issues" - 
2023-10-04 19:48:46.127190 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/970", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}
2023-10-04 19:48:46.921685 D [dry-run] ReleaseTools::GitlabClient -- [HTTParty] [2023-10-04 19:48:46 +0530] 200 "GET https://gitlab.com/api/v4/projects/15642544/issues/971/notes" - 
2023-10-04 19:48:46.924092 I [dry-run] ReleaseTools::Security::NotifyStableBranchCreation -- Posting stable branch creation notification to issue -- {:issue=>"https://gitlab.com/gitlab-org/security/gitlab/-/issues/971", :stable_branch_name=>"16-5-stable", :body=>"@rpereira2 The stable branch `16-5-stable` has been created. To be included in https://gitlab.com/gitlab-org/gitlab/-/issues/426612, please create a backport targeting the stable branch, following the security release MR template. If this backport is not needed, please notify the `@gitlab-org/release-managers` and apply the ~\"reduced-backports\" label to this issue. **When this issue is ready, apply the ~\"security-target\" label for it to be processed and linked to the upcoming security release.**"}

📦 Helm release
2023-10-04 19:48:46.925007 I [dry-run] ReleaseTools::PublicRelease::HelmGitlabRelease -- Not releasing Helm for an RC -- {:version=>"7.5.0", :gitlab_version=>"16.5.0-rc42-ee"}

Author Check-list

Has documentation been updated?

Edited Oct 05, 2023 by Reuben Pereira

Call NotifyStableBranchCreation when stable branch is created

What does this MR do and why?

Content

Testing

Author Check-list

Merge request reports