Skip to content

Removes critical logic from blog post validator

Mayra Cabrera requested to merge removes-critical-logic-from-blog-post-validator into master

What does this MR do and why?

Removes critical logic from blog post validator

During the last critical security release, the 'notify:release' job failed because the blog post couldn't be found.

https://ops.gitlab.net/gitlab-org/release/tools/-/jobs/11233647

2023-09-18 19:52:37.203435 I [security] ReleaseTools::Security::Finalize::BlogPostValidator -- Validating blog post url -- {:url=>"https://about.gitlab.com/releases/2023/09/18/critical-security-release-gitlab-16-3-4-released/"}
2023-09-18 19:52:37.512854 F [security] ReleaseTools::Security::Finalize::NotifyReleaseComplete -- The security release blog post couldn't be found or the pipeline in ChatOps failed to be created.

The blog post used the regular security release format (https://about.gitlab.com/releases/2023/09/18/security-release-gitlab-16-3-4-released/) without the critical in the URL. This commit updates the BlogPostValidator logic and removes the critical logic from it.

Related to gitlab-com/gl-infra/delivery#19662 (closed)

Author Check-list

  • Has documentation been updated?
Edited by Mayra Cabrera

Merge request reports