Skip to content

Add deploy_version label to deployment_duration_last_seconds metric

Reuben Pereira requested to merge rp/deploy-version-deployment-slo-metric into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Add deploy_version label to deployment_duration_last_seconds metric. The deploy_version value will be used as the "ID" to link different metrics and traces together.

Since we only have about 10 new versions a day (at this time), and Prometheus only holds data for a short time before the metrics are sent to long term storage in Thanos, the cardinality of the label should not be high enough to cause problems.

The deployment SLO dashboard uses max(delivery_deployment_duration_last_seconds) by (deployment_type, status) as query, so it should not be affected by a new label being added to the metric.

Author Check-list

  • Has documentation been updated?
Edited by Reuben Pereira

Merge request reports