Skip to content

Draft: Make auto_deploy:start job idempotent

Steve Abrams requested to merge delivery2523-idempotent-autodeploy-start-job into master

What does this MR do and why?

This makes the auto_deploy:start job idempotent by always updating the release metadata for CNG and Omnibus.

Previously, the metadata was only updated if the given project was tagged. If for some reason tagging occurred, but then the metadata update failed, running the job would fail because we would not retag, and thus not update the metadata. So now, we always update, even if tagging does not occur.

TODO:

  • Find out what happens if you try to make a commit to the release metadata that has no changes
  • Write a test proving the operation is now idempotent
  • Dry run test
  • Test beyond the dry run (if possible)

Author Check-list

  • Has documentation been updated?

Related to gitlab-com/gl-infra/delivery#2523 (closed)

Edited by Steve Abrams

Merge request reports