Skip to content

Split auto_deploy notification in two jobs

Mayra Cabrera requested to merge split-coordinated-notification-jobs into master

What does this MR do?

Split auto_deploy notification in two jobs

  • Adds two jobs into auto_deploy:finish:[env] stage, one to notify when a deployment is completed successfully, and another one to notify when a deployment failed
  • Increases test coverage for coordinated_pipeline_notification class

Related to gitlab-com/gl-infra/delivery#2034 (closed)

Manual QA

Succesful deployment to all our environments

✅ notify_success jobs executed, notify_failure jobs skipped
Screen_Recording_2021-09-15_at_16.11.25

Tests scenarios per environment

Environment Deployment fails, notify_failure executed Deployment is retried and succeeded, notify_success is executed
✅ gstg-cny Screen_Shot_2021-09-23_at_13.07.30 Screen_Shot_2021-09-23_at_13.18.18
✅ gstg  Screen_Shot_2021-09-23_at_13.53.18 Screen_Shot_2021-09-23_at_13.54.51
✅ cny Screen_Shot_2021-09-23_at_16.00.04  Screen_Shot_2021-09-23_at_16.03.39
✅ gprd Screen_Shot_2021-09-23_at_16.15.38 Screen_Shot_2021-09-23_at_16.17.36 
Notice how in this case, both notify_failure and notify_success are executed.

Author Check-list

  • [-] Has documentation been updated?
Edited by Mayra Cabrera

Merge request reports