Skip to content

Isolate auto-deploy change checks to builders

Robert Speicher requested to merge rs-auto-deploy-changes-check into master

There are two ways our auto-deploy builders can be considered changed:

  1. If the component versions have changed. In this case, we commit to the builder project.
  2. If the builder itself has changed, either via the commit above, or in the case of changes to the builder itself.

Previously, the first change check was performed by the builder, and the second by the tagger. This made it difficult to have a single source of truth for whether or not we would tag a new version.

Now both checks are performed in the Builder class, so that the Tagger is never even called if there's no reason to tag.

See gitlab-com/gl-infra/delivery#1353 (comment 453320294)

⚠ Review without whitespace changes.

Depends on !1308 (merged)

Edited by Robert Speicher

Merge request reports