Skip to content

Add validation of MRs in security implementation issue method

Mayra Cabrera requested to merge include-validation-of-security-mrs-in-implementation-issue into master

What does this MR do?

Modifies Security::ImplementationIssue#ready_to_be_processed? to also account for valid merge requests.

Currently #ready_to_be_processed? can return true even if one of the merge requests associated is invalid (because of a red pipeline, conflicts, etc). This MR changes the method's logic to also consider if the merge requests are valid or not. If they're not valid it assigns invalid merge requests as pending reason.

This helps to simplify the logic inside Security::MergeRequestBatchMerger service

As part of gitlab-com/gl-infra/delivery#1162 (closed)

Edited by Mayra Cabrera

Merge request reports