Fix empty labels being set in ApplyLabelsFromRelatedIssue
What does this MR do and why?
This MR prevents that empty labels (i.e. ~""
) are added to the /label
command in the ApplyLabelsFromRelatedIssue processor.
There are three possibilities in the processor right now, 1 and 2 are problematic:
- A command like
/label ~"" ~"type::maintenance"
is a noop (not applying typemaintenance!), - A command like
/label ~""
results in an error, and - A command like
/label ~"type::maintenance" ~""
correctly applies typemaintenance.
Expected impact & dry-runs
If an issue is related to an MR and the issue didn’t have a type label but group/section/stage labels, after this is merged, this will now correctly copy them over. That might be unexpected to MR authors but is the original impact when we added Introduce a new `ApplyTypeLabelFromRelatedIssue... (!1260 - merged).
Action items
-
If adding environment variables for reactive processors, update config/triage-web.yaml
and.gitlab/ci/triage-web.yml
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-
Edited by Kev Kloss