Prevent MrApprovedLabel from posting empty notes
What does this MR do and why?
Prior this change, this processor attempted to post empty comments if a MR was not approved.
This results in a 400 Bad Request:
400 Bad request - Note {:note=>["can't be blank"]}.
See https://new-sentry.gitlab.net/organizations/gitlab/issues/712950
Follow-up of !2837 (diffs, comment 1940727105)
Expected impact & dry-runs
These are strongly recommended to assist reviewers and reduce the time to merge your change.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.
Action items
-
If adding environment variables for reactive processors, update config/triage-web.yaml
and.gitlab/ci/triage-web.yml
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-
Edited by Peter Leitzen