Skip to content

Stop memoize incident

Jennifer Li requested to merge jennli-stop-memoize-issue into master

What does this MR do and why?

While investigating why the processor didn't trigger the expected Slack message, I found that I'm memoizing the incident object which shouldn't be memoized, because we need to look at its updated_at timestamp each time we call it.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Merge request reports