Skip to content

Use config selector in applicable method

Jennifer Li requested to merge jennli-use-config-selector into master

What does this MR do and why?

Reuse the same configSelector that we used for PiplineFailureManagement, as I noticed that the existing applicable? method in the UpdateMasterPipelineJobsStatus processor is not accurate.

This MR also fixes a small bug with the outdated_job? method, where it forgot to consider a job_payload.finished_at.nil? scenario which happens to manual jobs

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Jennifer Li

Merge request reports