Avoid setting on track when issue slipped previous milestone
What does this MR do and why?
See gl-retrospectives/plan#110 (closed)
During the 16.9 retrospective, a concern was raised regarding the Health Status feature being used to monitor progress and risks in deliverables. Despite missing several scheduled milestones, some issues were marked as "On Track," potentially misleading those depending on related deliverables. This was often due to automation marking issues as "On Track" when an assignee was present, regardless of missed milestones.
This change avoids resetting the health status to on track
if a missed-deliverable label is present. That would also leave the issues in on track
state, so an additional policy is added to set to needs attention
instead.
In other words, after this change the following will happen at the start of a new milestone:
- Issue slips milestone as
don't track health status
- no change (regardless of HS) - Issue slips milestone with no health status - set to
needs attention
- Issue slips milestone as
on track
- downgrade toneeds attention
- Issue slips milestone as
needs attention
- retain asneeds attention
- Issue slips milestone as
at risk
- retain asat risk
Expected impact & dry-runs
These are strongly recommended to assist reviewers and reduce the time to merge your change.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.
Action items
-
If adding environment variables for reactive processors, update config/triage-web.yaml
and.gitlab/ci/triage-web.yml
-
(If applicable) Add documentation to the handbook pages for Triage Operations => -
(If applicable) Identify the affected groups and how to communicate to them: -
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-