RuboCop: Disable new cops by default
What does this MR do and why?
The project gitlab-styles
is the single source of truth on
enabling/disabling cops.
Enabling them by default can cause issues in case cops are split into multiple cops.
For example: RSpec/FilePath
is replaced by RSpec/SpecFilePathSuffix
and
RSpec/SpecFilePathFormat
. The former is disabled in this project but
new cops are enabled by default which caused RuboCop failures after
upgrading rubocop-rspec
.
Refs !2638 (comment 1746846359)
Expected impact & dry-runs
These are strongly recommended to assist reviewers and reduce the time to merge your change.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.
Action items
-
If adding environment variables for reactive processors, update config/triage-web.yaml
and.gitlab/ci/triage-web.yml
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-