Skip to content

Separate mentions and assignees in stage/group reports

Context

  • #1094 (closed) was complaining that an assignee was mentioned twice in triage reports.
  • We implemented !1772 (merged) (by yours truly 🙈) to fix the problem, but this MR inadvertently disabled mentions for the people/groups listed in the extra_mentions: array.

What does this MR do and why?

Expected impact & dry-runs

Most triage report will be impacted. People present in the extra_mentions array should be notified in the next triage issue.

I picked one report as an example:

* Title: 2023-08-04 - Triage report for "group::pipeline authoring" - gitlab-org/gitlab
* Description: Hi `@dhershkovitch` `@marknuzzo` `@treagitlab` `@rayana` @sunjungp,

Looking at https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/317c08ce0125f4c3f216994be6f4ea9384782a72/group-definition.yml#L156-167, we only want the people mentioned in extra_mentions: to be pinged, so 🎉

(The assignees as also correctly set)

Action items

Edited by David Dieulivol

Merge request reports