Skip to content

Added relevant reviewer hint to ping incorrect reviewer label

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR adds the relevant reviewer hint:

If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with `@gitlab-bot ready @user1 @user2`.

that until now is can only be found on the "thank contribution greeting" (see here) also to the ping-incorrect-review-label notice.

This change could have helped me to mitigate some ping/bot spam to GitLab maintainers during my recent work on gitlab-org/gitlab!116913 (merged).

The workflow of my technical writer who offered to review my contribution was to remove himself from the reviewer assignees of this MR after every review. After I implemented the necessary changes I wanted to add him back "specifically" as a reviewer. The ping-incorrect-review-label message that was posted by the gitlab-bot after every reviewer removal didn't include the hint for the option to directly assign a specific reviewer.

As this had helped me a lot in that situation I wanted to enhance this message and copied the specific hint over from the "thank contribution greeting" message.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-policies-with-a-dry-run on how to perform dry-runs for new policies.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.

Action items

Edited by Daniel Haß

Merge request reports

Loading