Update require_type_on_refinement processor
What does this MR do and why?
Closes #1132 (closed)
This MR addresses a minor usability bug in the triage/processor/require_type_on_refinement.rb
processor, which does not check the added_label_names
array while deciding if a type label is added to the issue. The scenario is valid when a user uses the quick action to apply both workflow
and subtype
labels in one command, but our processor still rejects the workflow label because it only checks existing label name array for type label, while ignoring the type label that is about to be added.
Expected impact & dry-runs
These are strongly recommended to assist reviewers and reduce the time to merge your change.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs for new policies.
See https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/master/doc/reactive/best_practices.md#use-the-sandbox-to-test-new-processors on how to make sure a new processor can be tested.
Action items
-
If adding environment variables for reactive processors, update config/triage-web.yaml
and.gitlab/ci/triage-web.yml
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-