Filter in Ruby to work around API 500 error
What does this MR do and why?
Context: #1164 (comment 1216627782)
This requires (work-in-progress) gitlab-org/ruby/gems/gitlab-triage!270 (merged)
Expected impact & dry-runs
- (After,
filter_in_ruby: true
) Job duration 1 minute https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/3535174269* Found 963 resources... * Filtering resources... * Total after filtering: 16 resources * Limiting resources... * Total after limiting: 16 resources
Now comparing this to filtering in API:
- (Before,
filter_in_ruby: false
) Job duration 24 seconds https://gitlab.com/gitlab-org/quality/triage-ops/-/jobs/3535268243* Found 24 resources... * Filtering resources... * Total after filtering: 24 resources * Limiting resources... * Total after limiting: 24 resources
I believe using API should be faster, but who knows, maybe it's really less stable and 30 seconds isn't too much longer for something we run weekly anyway!
Action items
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> -
Relevant Slack channels => -
Engineering week-in-review
-
Edited by Lin Jen-Shin