Skip to content

Allow contributors to request reviews from other contributors

Marco Zille requested to merge zillemarco/triage-ops:zillemarco-allow-reviews-from-everyone into master

What does this MR do and why?

Related to gitlab-org/quality/contributor-success/team-task#100

With this MR I am removing the check to only allow the @gitlab-bot ready command to assign GitLab Team members only as reviewers, with the goal of allowing contributors to also help review MRs, hoping to lessen the burden on the GitLab Team and have them review more "mature" MRs 🙂

In the same MR I am also introducing a new reactive command, @gitlab-bot unassign_review, to allow community members to unassign themselves from review of an MR, otherwise impossible since they don't have admin rights over the reviewers list 🙂

Expected impact & dry-runs

@gitlab-bot ready command will be able to be used to also assign contributors as reviewers.

@gitlab-bot unassign_review command will be able to be used by community members to remove themselves from the reviewers' list (it also workd for Team members, it just wouldn't make much sense for them to use it).

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review
Edited by Marco Zille

Merge request reports