Skip to content

Explicitly exit with 0 or 1 for bin/health-check

Ash McKenzie requested to merge 1104-health-check-container-job-failing into master

What does this MR do and why?

This MR updates bin/health-check to explicitly exit with 0 (success) or 1 (error) to ensure subsequent commands are not executed.

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

See https://gitlab.com/gitlab-org/quality/triage-ops/-/tree/master/doc/scheduled#testing-with-a-dry-run on how to perform dry-runs.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Closes #1104 (closed)

Edited by Ash McKenzie

Merge request reports