Nudge for work types in projects part of the product
Context
Closes #1005 (closed)
This is the part 3/3 of the rollout plan.
What does this MR do?
We now nudge on MRs for projects that are part of the product.
Expected impact & dry-runs
- No dry-runs (reactive part)
More background jobs are to be expected, but seeing the current dashboard numbers for the job, the scale should be alright:
Before/After
Master
This MR
How to reproduce locally
It's a bit of a DIY setup:
- We work on this line in
part_of_product_projects.rb
:
# Before
.each { |hash| hash['project_id'] = hash['project_id'].to_i }
# After
.each { |hash| hash['project_id'] = hash['project_id'].to_i } + [{"project_path"=>"gitlab-org/build/david-test", "project_id"=>2}]
- Go to an MR in the
gitlab-shell
project (the one withid=2
), and try to add/remove labels to this MR: you should receive a nudge. - Go to another MR in another project, and try to add/remove labels to this MR: you should NOT receive a nudge.
Why is it SO DIY?
We do this setup because part_of_product_projects.rb
relies on production project_ids
. An alternative would be to change the ID of a project, but I couldn't easily do that locally in less time than this DIY hack
Action items
-
(If applicable) Add documentation to the handbook pages for Triage Operations => - (If applicable) Identify the affected groups and how to communicate to them:
-
/cc @ person_or_group
=> @gitlab-org/quality/engineering-productivity -
Relevant Slack channels => #development, #whats-happening-at-gitlab (not 100% sure about that one) -
Engineering week-in-review
-
Communication
David Dieulivol: (Rollout phase 3/3) Engineering Productivity will be rolling out merge request type reminders to all part of the product projects on 2022-06-03.
The reminder will add a merge request discussion to merge requests that are opened without a merge request type after a 5 minute grace period.
Please provide any feedback at gitlab-org/quality/engineering-productivity/team#43 (closed)