Skip to content

Do not trigger event if AppSec has approved

Kyle Wiebers requested to merge 960-check-approval into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Will not request review from AppSec if an MR is already approved. Currently a second request can happen if the new processor didn't request an AppSec review on an existing MR and the MR is approved like gitlab-org/gitlab-runner!3355 (comment 898034024).

Expected impact & dry-runs

These are strongly recommended to assist reviewers and reduce the time to merge your change.

Action items

  • (If applicable) Add documentation to the handbook pages for Triage Operations =>
  • (If applicable) Identify the affected groups and how to communicate to them:
    • /cc @person_or_group =>
    • Relevant Slack channels =>
    • Engineering week-in-review

Closes #960 (closed)

Merge request reports