Apply labels for the new Create:Code Review group (from Create: Source Code split)
Important: we're still confirming we've covered all the cases that can be automaticall updated. We'll update this message once we're ok to proceed and ping relevant team members. The cases have been confirmed, we can go ahead now.
Summary
This template is for the following types of label changes
- Adding a new Stage or Group
- Renaming an existing Stage or Group
For every case above, the Engineering Productivity team needs to ensure that:
- The label change is factored into the triage mechanism.
- Engineering Dashboards at https://quality-dashboard.gitlap.com/groups/gitlab-org are updated.
- Old labels are migrated correctly on affected issues and merge requests.
This issue tracks the following group changes:
Before | After |
---|---|
Create: Source Code | Create: Source Code, Create: Code Review |
Label migration plan (in progress)
Since the previously existing group has split into two different groups where one is keeping the same labels, the migration isn't straightforward.
Here's the list of migrations we've identify as able to infer from existing labels:
-
merge requests + groupsource code + open issues (list):
- add label groupcode review and ~"Category:Code Review"
- remove label Category:Source Code Management
- ~"Category:Code Review" (that don't have the label groupcode review) (list):
- add label groupcode review
Action items
-
(If applicable) Dashboard creation: create or update the stage/group in https://gitlab.com/gitlab-org/gitlab-insights/blob/master/lib/gitlab_insights.rb. -
(If applicable) Label migration on existing issues and merge requests: apply the new label to opened & closed issues, and open & merged merge requests. -
Check if label migration will apply labels which have subscribers. Communicate with the subscribers before applying the label migration.
-
-
(If applicable) Archive the old label with renaming and adding "DEPRECATED" at the end of the label name. -
(If applicable) Delete the old dashboard views using the deprecated labels. -
(If applicable) Update the group triage report definition to use the new label. -
(If applicable) Update the group label's description to refer to the new Stage.
(Not performed yet /cc @gl-quality/eng-prod
will do once the whole information on necessary migrations are compiled and agreed.)