Move discord messages to automated_review_request_generic
The discord messages for @gitlab-bot help
and @gitlab-bot ready
were enabled today.
We quickly found some small issues and this issue is for some opinions on moving the trigger point for @gitlab-bot ready
.
Identified issues
The discord message contains:
- Wrong labels
- Missing labels
- Missing reviewers
Identified reasons
The processor for @gitlab-bot ready
doesn't has all data available and the message operates with data which is changing after the processors for the changed labels trigger
Possible solution
Move the discord message from https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/fa34cda2575de502c1eaf68cdd3f5370e0803afe/triage/processor/community/command_mr_request_review.rb#L37 to https://gitlab.com/gitlab-org/quality/triage-ops/-/blob/fa34cda2575de502c1eaf68cdd3f5370e0803afe/triage/processor/community/automated_review_request_generic.rb#L27-29
Identified impacts
This will catch cases when the workflowready for review is added manually (either by a reviewer or by @gitlab-bot label
)
This will miss cases when the command is executed on a MR which already has workflowready for review set (which was didn't moved to workflowin review or workflowin dev)
It will remove the ability to intentionally "escape" the discord message by using @gitlab-bot label