Standardize page names when using .perform
In this issue I propose that we standardize page names when using:
Some::Page.perform do |page_name|
page_name.do_something
end
The main point is that in different tests, we define such pages differently. Below are some examples.
# qa/specs/features/browser_ui/1_manage/group/transfer_project_spec.rb
Page::Project::Show.perform do |project|
project.do_something
end
# qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
Page::Project::Settings::Members.perform do |page|
page.do_something
end
# qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb
Page::Project::Issue::Show.perform do |show_page|
show_page.do_something
end
# qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb
Page::Project::Issue::Show.perform do |issue_show_page|
issue_show_page.do_something
end
Decision (as per https://gitlab.com/gitlab-org/quality/team-tasks/issues/168#note_193718201):
We will use the name of page object being called, all lowercased (see example below.)
# qa/specs/features/browser_ui/1_manage/project/add_project_member_spec.rb
Page::Project::Settings::Members.perform do |members|
members.do_something
end
Cc @gl-quality
Edited by Walmyr Lima e Silva Filho