Update notification stage to be able to send failures even if no results are found
There is an issue with runner on staging, pipelines are failing: https://ops.gitlab.net/gitlab-org/quality/staging/pipelines
Example job: https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/706787. The same issue happens on Canary: https://ops.gitlab.net/gitlab-org/quality/canary/-/jobs/706881.
Notification job: https://ops.gitlab.net/gitlab-org/quality/staging/-/jobs/706779
$ ARTIFACT_DIR=$(find gitlab-qa-run-*/gitlab-* -type d -maxdepth 0 -print -quit)
find: gitlab-qa-run-*/gitlab-*: No such file or directory
Uploading artifacts...
WARNING: gitlab-qa-run-*: no matching files
WARNING: combined-report.html: no matching files
ERROR: No files to upload
Uploading artifacts...
WARNING: gitlab-qa-run-*/**/rspec-*.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1
However, we don't see any failure notifications in Slack, it just doesn't send anything:
Proposal: we need to update notification stage to be able to send failures even if no results are found
Discussion about the issue itself is here: https://gitlab.slack.com/archives/CBS3YKMGD/p1572432887089600, fixing MR: gitlab-org/quality/pipeline-common!10 (merged)