Standardize preconditions vs tests definitions
I propose that we standardize that tests preconditions always happen in before
or before(:all)
blocks, while the tests themselves are defined in the it
blocks.
In many cases, we don't have a clear separation of what is a precondition for the test and what are the actions and expectations of a test.
Below is a list of MRs where I have already started implementing what this issue suggests:
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30895
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30896
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30897
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30902
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30914
- https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30945/diffs
Cc @gl-quality
Edited by Walmyr Lima e Silva Filho