Skip to content

Add docs on review apps deployment process

David Dieulivol requested to merge 382162-add_docs_on_review_apps_deployment_process into main

What's in this MR?

Closes gitlab-org/gitlab#382162 (closed)

  • Explanations about what's happening after we deploy a review app in the network world.
  • Some small reorganization of the content (e.g. grouping, relabeling, ...)

Read the rendered markdown.

Why it matters

I think we could use the knowledge in there to have checks in verify_deploy function about what should happen for a review-app to be booted up:

  • The secret containing the certificate should be in the namespace
  • The TLS certificate is accessible:
REVIEW_APP_NAME=gitlab-review-nh-test-fu-4s1isx.gitlab-review.app

# This will give us the load balancer default TLS certificate (from default-backend)
openssl s_client -connect "${REVIEW_APP_NAME}:443" </dev/null | grep 'CN=Kubernetes Ingress Controller Fake Certificate'

# This will give us the TLS certificate of the actual review-app
openssl s_client -connect "${REVIEW_APP_NAME}:443" -servername "${REVIEW_APP_NAME}" </dev/null | grep 'subject=/CN=gitlab-review.app'
  • ...
Edited by David Dieulivol

Merge request reports