refactor: remove unsued clickhouse-client and indexer code

Jean-Gabriel Doyonrequested to merge
remove-clickhouse-engine-unused-code into main

What does this MR do and why?

Removes dead code from clickhouse-client and indexer crates.

In clickhouse-client: removed ArrowQuery::bind(), the ClickHouseConfiguration::from_env() / from_env_with_prefix() constructors and their env_var_or() helper, the re-exported ExtractError type, an empty param.rs file, and the associated tests.

In indexer: removed the optional lock_service field and setter from EngineBuilder. The lock service is now always constructed internally from NATS services, which was already the default; the setter was never called.

Performance Analysis

  • This merge request does not introduce any performance regression. If a performance regression is expected, explain why.

Merge request reports