Loading
Draft: feat: smoke-test the tests_with_code Danger rule (do not merge)
Do not merge. This MR is a throwaway that exercises the tests_with_code Danger rule from !3360 (merged) end to end. It is stacked on that branch and will be closed, not merged.
Results
| Run | Title | Change | danger-review |
Pipeline |
|---|---|---|---|---|
| 1 | feat: |
pagebound.go only |
failed, not allowed to fail | failed |
| 2 | refactor: |
pagebound.go only |
passed | passed |
| 3 | feat: |
pagebound.go and pagebound_test.go |
passed | passed |
- Run 1: the untested change to production Go fails
danger-reviewand the pipeline. Danger's comment namedinternal/pagebound; a screenshot is in !3360 (merged)'s description, because Danger has since edited the comment. - Run 2: the
refactor:title exempts the same commit. It is a new pipeline rather than a retry, so run 1 stays failed. - Run 3: a
_test.gochange in the same package clears the rule underfeat:.
docs:links fails in all three on four dead links that fail it on main too; it is allowed to fail.
Edited by Fiona McCawley