Skip to content

Resolve "Changing GitLab URL in gitlab.rb does not update Mattermost GitLab OAUTH configuration"

Jason Plum requested to merge 3199-mattermost-dont-store-auth-endpoints-in-secrets into master

What does this MR do?

Mattermost: Don't store GitLabSettings.*Endpoint in gitlab-secrets.yml

Fixes: #3199 (closed)

Because we stashed GitLabSettings.*Endpoint with the rest of the MM secrets in gitlab-secrets.yml, changing external_url would not result in a change to the *Endpoint values.

Remove these values from being stored in gitlab-secrets.yml

I am unsure if additional work is needed to automatically ignore these settings if present in gitlab-secrets.yml, or if manual intervention will be required by the user.

Checklist

See Definition of done.

  • Change added to CHANGELOG.md. Not applicable for Documentation changes and minor changes.
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA, if applicable
  • MR targeting master branch
  • MR has a green pipeline on GitLab.com

Reviewer Checklist

In addition to above, reviewer must:

  • Pipeline is green on dev.gitlab.org if the change is not touching documentation or internal cookbooks

References

Edited by Jason Plum

Merge request reports