Push QA images to registry
This should address gitlab-qa#81 (comment 44232938). Also part of https://gitlab.com/gitlab-org/gitlab-ce/issues/39637.
- Add
Build::QA
to handle QA-specific logic - Add a new
Build::Image
module that is extended inBuild::GitlabImage
andBuild::QAImage
. -
Build::GitlabImage
andBuild::QAImage
only definedockerhub_image_name
andgitlab_registry_image_name
so that all theget
,tag
,push
logic is centralized inBuild::Image
- Renamed the GitLab QA images to
gitlab-{ce,ee}-qa
and removed the edition from the tag since it would be redundant. - Push the QA images after building it so that
gitlab-qa
(the gem) will use this image when runningComponent::Specs#perform
in theqa:test
task. - Improved the tests and coverage of all the classes under
lib/build
- Improved the tests and coverage of
lib/docker_operations.rb
- Improved the tests and coverage of
lib/tasks/docker_tasks.rake
andlib/tasks/qa.rake
Closes gitlab-qa#81 (closed) and gitlab-qa#106 (closed).
/cc @grzesiek
Edited by GitLab Release Tools Bot