Checking the rails nodejs licenses fails
Currently we move the node_modules
folder for caching before the license_scout runs, so we haven't been checking the nodejs licenses.
While working on this change: !2729 (merged) we re-introduced the license check for node modules, but our builds started failing with this error:
bundler: failed to load command: omnibus (/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bin/omnibus)
ArgumentError: comparison of Hash with Hash failed
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/gems/license_scout-1.0.10/lib/license_scout/reporter.rb:42:in `sort'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/gems/license_scout-1.0.10/lib/license_scout/reporter.rb:42:in `block in report'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/gems/license_scout-1.0.10/lib/license_scout/reporter.rb:38:in `each'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/gems/license_scout-1.0.10/lib/license_scout/reporter.rb:38:in `report'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bundler/gems/omnibus-2ed670aa5187/lib/omnibus/licensing.rb:590:in `check_transitive_dependency_licensing_errors_for'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bundler/gems/omnibus-2ed670aa5187/lib/omnibus/licensing.rb:150:in `execute_post_build'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bundler/gems/omnibus-2ed670aa5187/lib/omnibus/software.rb:1212:in `block in execute_build'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bundler/gems/omnibus-2ed670aa5187/lib/omnibus/software.rb:1212:in `each'
/builds/gitlab/omnibus-gitlab/gems/ruby/2.4.0/bundler/gems/omnibus-2ed670aa5187/lib/omnibus/software.rb:1212:in `execute_build'
We should further investigate this error, and whether we want to run the license check for the node_modules.