Remove package OS check from deployer task
What does this MR do?
Remove the package OS check from the gitlab_com:deployer rake task. The deployer task only triggers a deployment pipeline with a version and does not use the built package directly. The OS check is unnecessary and can prevent deployments from being triggered when no matching packages are present.
The current trigger deployer is to only trigger a pipeline if the built package has the same OS version of the target environment. This logic does not work and unnecessary:
- Does not work: the Rake task call is already moved to its own CI
job
deployer-trigger, so there is no package attached to the job. - Unnecesary: The
deployerpipeline is trigger with only DEPLOY_VERSION, DEPLOY_USER and DEPLOY_ENVIRONMENT, so the OS version is irrelevant.
Related issues
gitlab-com/gl-infra/delivery#22000 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
- The UBT version and corresponding checksum hash have been updated and referenced in the merge request if applicable.
- UBT EE pipeline (
Trigger:ee-package-ubt) is green
- UBT EE pipeline (
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
- The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit.- To debug QA failures, refer to the Investigate QA failures section.
- If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. - If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. - If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
- Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme[REDACTED]host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Dat Tang