ci: Do not allow pulp jobs to fail
What does this MR do?
Since packagecloud jobs are now optional (gated by PACKAGECLOUD_ENABLED), pulp jobs are the primary upload path and should be required to succeed. This removes allow_failure: true from both .pulp_staging_upload_template and .pulp_production_release_template.
Related issues
Ref:
- https://gitlab.com/gitlab-org/omnibus-gitlab/-/work_items/9552+
- https://gitlab.com/gitlab-org/build/team-tasks/-/work_items/177+
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
-
The UBT version and corresponding checksum hash have been updated and referenced in the merge request if applicable.
-
UBT EE pipeline (
Trigger:ee-package-ubt) is green
-
UBT EE pipeline (
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit.- To debug QA failures, refer to the Investigate QA failures section.
-
If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
-
Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Dat Tang