gitlab-rails small cleanup to bring the package file count down
What does this MR do?
SLES 12 sp 5 is running rpm 4.11.2 .
This version has a max limit of 16 mebibytes that it accepts in the header data of an installed rpm in the rpm database.
We're close to breaching this limit on this distro. Often we find ourselves just a few hundreds of bytes above the limit.
In this MR I am removing:
Under embedded/service/gitlab-rails
- .gitlab folder You can see its contents here - 179 files
Under embedded/lib/ruby/gems:
- .gitlab-ci.yml files - 16 files
- .gitignore - 198 files
- .travis.yml - 65 files
- .rubocop*.yml - 97 files
- .rspec - 97 files
- .github folders - 221 files
For now I think this cleanup is enough
Related issues
Related issue: #9647
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit. -
If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
-
Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Stefan Constantin