Add SSL parameters to ActionCable config
What does this MR do?
While !7151 (merged)
added the ssl_params configuration settings, ActionCable did not have
this. As a result, systems that needed mutual TLS with Redis or a
specific certificate store did not work.
Fix this by adding the ssl_params settings to cable.yml if
necessary.
Related issues
Related to #6422.
Also see #8856.
How to test locally
In /etc/gitlab/gitlab.rb:
redis['bind'] = '0.0.0.0' # or specify an IP to bind to a single one
redis['port'] = 6380
Run gitlab-ctl reconfigure.
cat /var/opt/gitlab/gitlab-rails/etc/cable.yml should show:
production:
adapter: redis
url: rediss://localhost:6380/
ssl_params:
ca_path: "/opt/gitlab/embedded/ssl/certs/"
ca_file: "/opt/gitlab/embedded/ssl/certs/cacert.pem"
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit. -
If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
-
Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Hossein Pursultani