Fix RHEL 10 not working with SELinux
What does this MR do?
This commit refactors SELinux RHEL version checks to use a version
comparison. Replace individual RHEL version checks (RHEL 7, 8, 9, 10)
with a system_is_supported_rhel? method that performs numeric
comparison. This simplifies the selinux_supported? check.
Related issues
How to validate locally
- Create a RHEL 10 VM.
- Install this package. You should see the
gitlab::selinuxrecipe do its thing:
Recipe: gitlab::selinux
* execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-7.2.0-ssh-keygen.pp] action run[2025-12-05T07:04:14+00:00] INFO: execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-7.2.0-ssh-keygen.pp] ran successfully
- execute semodule -i /opt/gitlab/embedded/selinux/gitlab-7.2.0-ssh-keygen.pp
* execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-10.5.0-ssh-authorized-keys.pp] action run[2025-12-05T07:04:19+00:00] INFO: execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-10.5.0-ssh-authorized-keys.pp] ran successfully
- execute semodule -i /opt/gitlab/embedded/selinux/gitlab-10.5.0-ssh-authorized-keys.pp
* execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-13.5.0-gitlab-shell.pp] action run[2025-12-05T07:04:25+00:00] INFO: execute[semodule -i /opt/gitlab/embedded/selinux/gitlab-13.5.0-gitlab-shell.pp] ran successfully
- execute semodule -i /opt/gitlab/embedded/selinux/gitlab-13.5.0-gitlab-shell.pp
- Also run
semodule -l:
# semodule -l | grep gitlab
gitlab-10.5.0-ssh-authorized-keys
gitlab-13.5.0-gitlab-shell
gitlab-7.2.0-ssh-keygen
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit. -
If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
-
Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall