Disable allow_failure for the check-packages-functionality job in the tag pipelines

Mawreen Dela Cruzrequested to merge
mdc/check-packages-functionality-failure into master

What does this MR do?

During the RC tagging for the 18.6 monthly release, we encounter a failure in the Docker job in the Update VERSION to 18.6.0-rc43-ee pipeline. Fortunately, Balu was able to see it before we tag the final release.

Upon checking, the same error happened in the RC42 tag, but since the check-packages-functionality trigger job shows as successful, the release tooling is not able to see this as part of the RC validations:

If we (RMs) were not tagged by the Build team (Balu), we might not have noticed this and tagged the final release. This will cause the final release to be broken and might put us in a difficult situation, given that tomorrow is the release day.

This MR is to propose to remove the allow_failure from the check-packages-functionality trigger job. This change will help us identify failures more easily and reduce false positives.

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Mawreen Dela Cruz

Merge request reports