Enable gRPC ingress on KAS
What does this MR do?
This MR enables gRPC ingress to KAS. In short, earlier gRPC calls were tunneled in a Websocket tunnel and with this change agentk will be able to connect to KAS.
How can this change be tested?
-
Run agentk with this command
bazel run //cmd/agentk -- --kas-address=grpcs://<gitlab-instance-url> --token-file=<FILE-PATH> -
agentkshould be able to connect to KAS.
Related issues
Implement gRPC ingress support (gitlab-org/cluster-integration/gitlab-agent#766)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-packagejobs have a green pipeline running against latest commit. -
Ifconfig/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. -
If you are changing anything SSL related, then theTrigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed toto confirm regular branch builds aren't broken.dev.gitlab.org
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added.(I did not find any tests associated with nginx conf templates) -
Integration tests added toGitLab QA. (I did not find any tests associated with nginx conf templates) -
Equivalent MR/issue for theGitLab Chartopened.(Yet to be opened, but it should not break anything) -
Validate potential values for new configuration settings. Formats such as integer(No value is necessary)10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Ashvin Sharma