Preinstall: Optionally skip config check

Clemens Beckrequested to merge
6412-skip-conf-check into master

What does this MR do?

Preinstall: Optionally skip config check

The config check during preinstall can cause problems in specific situations such as when the user is looking to install the package only and skip reconfigure as an iterative step in their process.

User's can now make the config check non-blocking by creating a /etc/gitlab/skip-fail-config-check file.

Changelog: added

Related issues

Closes Add option to skip deprecated config check duri... (#6412 - closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Test Plan

  • Install a stable package (e.g. 17.11.4).

  • Set a deprecated/removed setting in gitlab.rb. E.g.:

    gitlab_shell['migration'] = { 'foo': 'bar'} # removed in 18.0

  • Run reconfigure.

  • Upgrade to the package build of this MR.

  • This is expected to fail.

    Deprecations found. Please correct them and try again.
... E: Sub-process /usr/bin/dpkg returned an error code (1)

  • Create the file to skip the next check during preconfigure:

    echo "1" > /etc/gitlab/skip-fail-config-check

  • Rerun apt upgrade. The deprecations should be printed, but we no longer exit early.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Closes #6412 (closed)

Edited by Hossein Pursultani

Merge request reports