Skip to content

Use `openssl rehash` instead of `c_rehash`

What does this MR do?

Use openssl rehash instead of c_rehash

c_rehash is considered legacy and might be removed in future OpenSSL releases.

Benefits of openssl rehash:

Related issues

Closes Switch to `openssl rehash` instead of `c_rehash... (#6579 - closed)

Test plan

  1. Place a root CA cert to /etc/gitlab/trusted-certs/custom.crt.

  2. Validate that the generated CA bundle is the same for openssl rehash and c_rehash:

    # check trusted certs
    $ ls -l  /etc/gitlab/trusted-certs/
    total 4
    lrwxrwxrwx 1 root root   10 Apr  8 11:49 9da13359.0 -> custom.crt
    -rw-r--r-- 1 1001 1001 1245 Apr  8 11:35 custom.crt
    # check generated bundle
    $ ls -l /opt/gitlab/embedded/ssl/certs
    total 224
    lrwxrwxrwx 1 root root     36 Apr  8 13:06 9da13359.0 -> /etc/gitlab/trusted-certs/custom.crt
    -rw-r--r-- 1 root root    147 Apr  8 13:06 README
    -rw-r--r-- 1 root root 224369 Apr  8 11:59 cacert.pem
    $ md5sum /opt/gitlab/embedded/ssl/certs/cacert.pem 
    9789f819c118477ff642b66c2e03cb7b  /opt/gitlab/embedded/ssl/certs/cacert.pem

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Closes #6579 (closed)

Edited by Clemens Beck

Merge request reports

Loading