Skip to content

Check packages does not have .dind job in scope

Robert Marshallrequested to merge
fix-check-packages-dind-issue into master

What does this MR do?

Check packages does not have .dind job in scope

- The check packages job runs on a trigger. The trigger is the base CI
  configuration, and due to that, it does not have the job definition
  for `.dind` in scope. This moves the `.dind` definition to a modular
  include so that we can include it where necessary without any
  additional baggage that could confuse the pipeline.

Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/8988

Signed-off-by: Robert Marshall <rmarshall@gitlab.com>

Related issues

Related Pipeline failure for e4c1cb1ede1d9de18b82bbec29... (#8988 - closed) • Unassigned

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Merge request reports