Add prawn, prawn-table, and prawn-svg to omnibus allowlist

What does this MR do?

Context

We want to use prawn, prawn-table, and prawn-svg to build out PDF reporting features for our security features.

We previously built a proof of concept, and have decided to move forward implementing the report with prawn1

Before beginning the development work, we need to:2

This MR

Add the packages to the license allowlist

Testing

  1. Running the e2e:test-on-omnibus-ee in the MR adding the gems, it fails.
  2. I then pointed the branch at this omnibus branch with this change:
    diff --git a/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml b/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml
    index 17eba785b9457201e6792569763fb7066dad001e..697efd2f1917794e82b91350951a84367d0349bf 100644
    --- a/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml
    +++ b/.gitlab/ci/qa-common/omnibus.gitlab-ci.yml
    @@ -95,7 +95,7 @@ trigger-omnibus:
         ee: $EE
       trigger:
         project: gitlab-org/build/omnibus-gitlab-mirror
    -    branch: $TRIGGER_BRANCH
    +    branch: "mbecker/tasks/add-prawn-gems-to-omnibus"
         strategy: depend
     
     trigger-omnibus as-if-foss:
  3. Then, re-running the e2e:test-on-omnibus-ee job and it passed

References

Related issues

closes Legal review of Prawn licensing (gitlab#524059 - closed) • Michael Becker • 18.0 • On track

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated. n/a
  • Tests added. n/a
  • Integration tests added to GitLab QA. n/a
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file. n/a
  1. The proof of concept MR builds out a demo using the gems

  2. These steps come from the "Getting an Unknown Licensed Software Approved" and Legal's handbook page on "Using Open Souce Software"

  3. License approval was already obtained here

Edited by Michael Becker

Merge request reports

Loading