Force older x86 platforms to recompile native gems
What does this MR do?
As described in https://github.com/rake-compiler/rake-compiler-dock/issues/122, x86 precompiled native gems for a long time have used an image based on CentOS 7, which uses glibc 2.17.
With https://github.com/rake-compiler/rake-compiler-dock/pull/126, the image has been updated to Ubuntu 20.04, which uses glibc 2.29.
In OhaiHelper#ruby_native_gems_unsupported?
, we previously forced a
number of older aarch64
platforms to recompile the native gems
because aarch64
has used Ubuntu 20.04 and hence glibc 2.29 for a
while.
With gems that use rake-compiler-dock v1.6.0 or higher (e.g. nokogiri, prometheus-client-mmap, etc.), glibc 2.29 is now required even for x86.
In preparation for these gem updates, ensure that all native Ruby gems are recompiled to avoid quiet failures.
Relates to #8865 (closed)
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Merge request reports
Activity
added devopssystems groupdistribution sectioncore platform labels
assigned to @stanhu
added groupcloud connector label and removed groupdistribution label
- A deleted user
added typebug label
3 Warnings You've made some changes to the software definitions.
Any change in software definition requires:
- package rebuild to verify that builds across the supported platforms are successful.
- manual verification to confirm the package is installable
- uses an approved license
If the change does not affect existing functionality, for example when
resolvingrubocop
warnings, adding comments, or fixing typos, add one of
the following labels:You've made some changes in the cookbooks, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding the typemaintenance label in that case.Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @WarheadsSE
(UTC-5, 3 hours ahead of
@stanhu
)@apatterson2
(UTC-7, 1 hour ahead of
@stanhu
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded Category:Cloud Connector label
E2E Test Result Summary
allure-report-publisher
generated test report!qa-subset-test:
test report for 5b8bc4e0expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Govern | 24 | 0 | 1 | 0 | 25 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Monitor | 4 | 0 | 1 | 0 | 5 | ✅ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Package | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 1 | 0 | 0 | 0 | 1 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 47 | 0 | 4 | 0 | 51 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Usermentioned in merge request gitlab!176631 (merged)
mentioned in issue #8865 (closed)
- Resolved by Balasankar 'Balu' C
added 1 commit
- 09dc0fa1 - Force older x86 platforms to recompile native gems
changed milestone to %17.8
- Resolved by Balasankar 'Balu' C
added 9 commits
-
1af2f0cf...337e2e89 - 8 commits from branch
master
- b2f52a9a - Force older x86 platforms to recompile native gems
-
1af2f0cf...337e2e89 - 8 commits from branch
added 1 commit
- cca50691 - Force older x86 platforms to recompile native gems