Skip to content
Snippets Groups Projects

Force older x86 platforms to recompile native gems

Merged Stan Hu requested to merge sh-glibc-fix-rake into master

What does this MR do?

As described in https://github.com/rake-compiler/rake-compiler-dock/issues/122, x86 precompiled native gems for a long time have used an image based on CentOS 7, which uses glibc 2.17.

With https://github.com/rake-compiler/rake-compiler-dock/pull/126, the image has been updated to Ubuntu 20.04, which uses glibc 2.29.

In OhaiHelper#ruby_native_gems_unsupported?, we previously forced a number of older aarch64 platforms to recompile the native gems because aarch64 has used Ubuntu 20.04 and hence glibc 2.29 for a while.

With gems that use rake-compiler-dock v1.6.0 or higher (e.g. nokogiri, prometheus-client-mmap, etc.), glibc 2.29 is now required even for x86.

In preparation for these gem updates, ensure that all native Ruby gems are recompiled to avoid quiet failures.

Relates to #8865 (closed)

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Stan Hu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Stan Hu changed the description

    changed the description

  • Stan Hu added 1 commit

    added 1 commit

    • 09dc0fa1 - Force older x86 platforms to recompile native gems

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • 7f7daf07 - Attempt to build Ruby with gcc 5 on SLES 12

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • 1af2f0cf - Test build with GCC 8 with SLES12

    Compare with previous version

  • Stan Hu changed milestone to %17.8

    changed milestone to %17.8

  • Stan Hu
  • Stan Hu added 9 commits

    added 9 commits

    Compare with previous version

  • Stan Hu added 1 commit

    added 1 commit

    • cca50691 - Force older x86 platforms to recompile native gems

    Compare with previous version

  • Stan Hu marked the checklist item MR title and description are up to date, accurate, and descriptive. as completed

    marked the checklist item MR title and description are up to date, accurate, and descriptive. as completed

  • Stan Hu marked the checklist item MR targeting the appropriate branch. as completed

    marked the checklist item MR targeting the appropriate branch. as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading