Skip to content

Force ffi gem to use Ruby platform gem

Stan Hu requested to merge sh-ffi-force-ruby-platform-17-1 into 17-1-stable

This backports !7730 (merged) to 17-1-stable to eliminate the possibility of seeing these warning messages that are harmless:

ffi-libarchive could not be loaded, libarchive is probably not installed on system, archive_file will not be available

ffi v1.17.0 started shipping precompiled native gems for x86 and aarch64 Linux. However, these precompiled gems don't include the Omnibus library path (/opt/gitlab/embedded/lib) as part of the default LD_LIBRARY_PATH, so libraries such as libarchive can't be loaded from Omnibus.

Bundler allows us to ignore the precompiled gems by using force_ruby_platform in the Gemfile, so use this feature to effectively restore the behavior in previous ffi gem versions.

Related issues

Relates to #8590 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall

Merge request reports