Skip to content

Disable request buffering for new SSH endpoints

Vasilii Iakliushin requested to merge 466160_disable_request_buffering into master

What does this MR do?

Contributes to gitlab#466160 (closed)

Problem

While testing the new implementation of SSH endpoints for git related actions. I noticed a problem reproducible in my local environment.

The request from GitLab-Shell to Workhorse was hanging. After in investigation I discovered the root cause of this problem.

In our NGINX configuration we use request buffering. After adding the new endpoint to the list of exceptions, then problem was resolved.

Solution

Add new endpoints to the list of exceptions for nginx configuration.

Related issues

gitlab#466160 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Vasilii Iakliushin

Merge request reports

Loading