Skip to content

Backport: RSpec changes for .com handling nightly packages

Stan Hu requested to merge backport-com-nightly-16-4 into 16-4-stable

What does this MR do?

This backports !7434 (merged) (and !7471 (merged)) to 16-4-stable. See https://gitlab.com/gitlab-org/gitlab/-/issues/462157.

Why

All branches prior to 16-10-stable need to have the unset_all_env_variables included, as while this variable is protected, it will still impact tags / branches as seen by the most recent security release process.

What

Merge branch 'run-nightly-in-com' into 'master'

Enable running nightly pipelines in Canonical repo

See merge request !7434 (merged)

Merged-by: Andrew Patterson apatterson@gitlab.com Approved-by: Clemens Beck cbeck@gitlab.com Approved-by: Andrew Patterson apatterson@gitlab.com Reviewed-by: Balasankar 'Balu' C balasankar@gitlab.com Co-authored-by: Balasankar 'Balu' C balasankar@gitlab.com

(cherry picked from commit a09322cd)

eef878ae Enable running nightly pipelines in Canonical repo ef20ff97 Use package from artifacts for Docker build job in nightlies also 64fc395c Improve documentation and verbosity of package upload logic ce17360c Stub package upload related env variables ed68d7cd Allow nightly repos to be controlled via env variable

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated.
  • Tests added.
  • Integration tests added to GitLab QA.
  • Equivalent MR/issue for the GitLab Chart opened.
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Stan Hu

Merge request reports