Skip to content

Override default timeout when running decomposition migration

Rutger Wessels requested to merge 434465-shell-execution-timeout into master

What does this MR do?

During testing of migrating a large database to two database setup, we noticed that using GitlabCtl::Util.run_command will run a command but will raise a timeout exception after 5 minutes. Since migrating the database can take more than 5 minutes, this MR will set the timeout to 1 day. I could not find a way of disabling the timeout: setting to nil will set the default to 600.

Related issues

gitlab#434465 (closed)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • MR title and description are up to date, accurate, and descriptive.
  • MR targeting the appropriate branch.
  • Latest Merge Result pipeline is green.
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

  • The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
  • If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
  • If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
  • If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes.
  • Documentation created/updated. (no need for documentation)
  • Tests added.
  • Integration tests added to GitLab QA. No need for this
  • Equivalent MR/issue for the GitLab Chart opened: No need, we advise to run the script from a shell
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file. No configuration settings

Test plan

Result: script should run without errors

Edited by Rutger Wessels

Merge request reports