Unified Backups: Fix missing bin directory
What does this MR do?
This MR is a followup of !7328 (comment 1843138784) to fix the missing bin directory.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Merge request reports
Activity
added devopssystems groupdistribution sectioncore platform labels
requested review from @balasankarc
changed milestone to %16.11
added Category:Backup/Restore of GitLab instances GitLab Free featureaddition groupgeo missed:16.10 typefeature workflowin review + 1 deleted label and removed groupdistribution label
added workflowready for review label and removed workflowin review label
removed missed:16.10 label
added groupdistribution label and removed groupgeo label
added groupgeo label and removed groupdistribution label
added groupdistribution group::distributiondeploy labels and removed groupgeo label
2 Warnings 9a0c4c8d: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. You've made some changes to the software definitions.
Any change in software definition requires:
- package rebuild to verify that builds across the supported platforms are successful.
- manual verification to confirm the package is installable
- uses an approved license
If the change does not affect existing functionality, for example when
resolvingrubocop
warnings, adding comments, or fixing typos, add one of
the following labels:1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @vishal.s.patel
(UTC+5.5)
@ibaum
(UTC-4)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Peter Lu
mentioned in commit 874a7012
mentioned in commit 028fa64a
mentioned in merge request !7520 (closed)
added workflowstaging-canary label and removed workflowready for review label
mentioned in issue gitlab-org/release/tasks#9930 (closed)