Enable skopeo for container releases
Enable skopeo for container releases
- Adds option that enables container copies with skopeo
instead of pull the image, re-tag, and then push it
- Retains current pull/re-tag/push behavior as default
Related https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5673
Signed-off-by: Balasankar 'Balu' C <balasankar@gitlab.com>
What does this MR do?
Move away from the pull-retag-push logic for releasing Docker images towards skopeo copy
. This will help when we finally do multiarch images.
Testing
Unfortunately, this is kinda impossible to test in live without setting up a lot of infrastructure. Hence, I added an env variable flag to control this, so we can test this in nightlies. The default flow still remains the same.
Related issues
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manual Trigger:ee-package
jobs have a green pipeline running against latest commit. -
If config/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then the Trigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed to dev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer 10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Edited by Robert Marshall